Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow forcing WebGPU/WebGL on the web player, new command line argument to force graphics backend #4981

Merged
merged 13 commits into from
Feb 1, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 31, 2024

What

Bunch of related things that go in here:

  • url parameter to force webgl/webgpu: &renderer=webgpu or &renderer=webgl
  • command line argument with similar syntax, can be used both for web player and native e.g. --renderer gl, --web-viewer --renderer webgpu
  • show webgpu/webgl url on crash
  • ui action for reloading webpage with webgpu or webl
  • updated trouble shooting docs on

Parsing of backend is actually fairly fuzzy but in docs I stick with wgpu names. Front facing we talk usually about "renderer" but internally we're more correct and call it "wgpu backend" which requires knowing a bit more about how things work.

webgpuwebglswitch.mp4

Screen on crash:
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added enhancement New feature or request 🕸️ web regarding running the viewer in a browser include in changelog labels Jan 31, 2024
@emilk
Copy link
Member

emilk commented Feb 1, 2024

  • url parameter to force webgl/webgpu: &renderer=webgpu or &renderer=webgl
  • command line argument with similar syntax, can be used both for web player and native e.g. --force-renderer gl, --web-viewer --force-renderer webgpu

Let's be consistent, and use --renderer

@Wumpf
Copy link
Member Author

Wumpf commented Feb 1, 2024

done, it's --renderer now

crates/re_renderer/src/config.rs Outdated Show resolved Hide resolved
crates/re_renderer/src/config.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/app.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit df849d7 into main Feb 1, 2024
40 checks passed
@Wumpf Wumpf deleted the andreas/force-graphics-backends branch February 1, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request include in changelog 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to force WebGPU / WebGL
2 participants